[FieldTrip] ft_rejectvisual reduces trial length

[Snijders, T.M. (Tineke)]

Thanks for fixing this Jan-Mathijs, it works beautifully now!


Tineke



________________________________
From: fieldtrip <fieldtrip-bounces at science.ru.nl> on behalf of Schoffelen, J.M. (Jan Mathijs) <jan.schoffelen at donders.ru.nl>
Sent: Friday, November 9, 2018 11:18 AM
To: FieldTrip discussion list
Subject: Re: [FieldTrip] ft_rejectvisual reduces trial length

Hi Tineke,

This is indeed inappropriate behaviour of the function, which has been tracked down to something going wrong in ft_selectdata.
I have submitted a PR https://github.com/fieldtrip/fieldtrip/pull/873 on the github-repo which fixes the issue https://github.com/fieldtrip/fieldtrip/issues/871
I am pretty sure that this fix does not come with unwanted side effects, but since ft_selectdata is used almost everywhere I'd appreciate some moral support before merging.

Let me know what you think.

Jan-Mathijs

PS: for those who are around: please do join Tineke and me this coming Sunday Nov 11, when we will commemorate the centenary of the 1918 armistice with a choral concert at the church of St. Anthony of Padua in Nijmegen. It starts at 15.30, see http://www.kamerkoormnemosyne.nl


J.M.Schoffelen, MD PhD
Senior Researcher, VIDI-fellow - PI, language in interaction
Telephone: +31-24-3614793
Physical location: room 00.028
Donders Centre for Cognitive Neuroimaging, Nijmegen, The Netherlands



On 7 Nov 2018, at 13:28, Snijders, T.M. (Tineke) <tineke.snijders at donders.ru.nl<mailto:tineke.snijders at donders.ru.nl>> wrote:

Hi,

I am using trials of different lengths, which seems to give a problem in ft_rejectvisual. It wasn't a problem before (I think in 2016) when I did the same analysis.

When using ft_rejectvisual, in the current fieldtrip version in the output data all trial lengths are reduced to the shortest trial-length, cutting away the remainder of the trial. In the command window it gives a warning of 'inconsistent sampling info'.

Is there a workaround to still get the full trial-lengths for the artifact rejected data? I do want to keep the complete trials at this point.

Thanks,

Tineke

--
Dr T.M. Snijders
Research Staff
Max Planck Institute for Psycholinguistics, Nijmegen
www.ru.nl/people/donders/snijders-t<https://mail.ru.nl/owa/redir.aspx?C=aE18Q9YtGk2rr44ef6ljnvavJ_le59EI7kXp3hhsUOBUcLdMm7SXiF0EPl90EamEoz9Ik4FGfek.&URL=http%3a%2f%2fwww.ru.nl%2fpeople%2fdonders%2fsnijders-t>
http://www.mpi.nl/departments/language-development<https://mail.ru.nl/owa/redir.aspx?C=aE18Q9YtGk2rr44ef6ljnvavJ_le59EI7kXp3hhsUOBUcLdMm7SXiF0EPl90EamEoz9Ik4FGfek.&URL=http%3a%2f%2fneurobiologyoflanguage.com%2f>

MPI | Wundtlaan 1 | Room 246 | tel 024 35 21246 | PO Box 310 | 6500 AH Nijmegen


_______________________________________________
fieldtrip mailing list
https://mailman.science.ru.nl/mailman/listinfo/fieldtrip
https://doi.org/10.1371/journal.pcbi.1002202



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.science.ru.nl/pipermail/fieldtrip/attachments/20181115/71059357/attachment-0002.html>