<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!--P{margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr" style="font-size:10pt;color:#000000;background-color:#FFFFFF;font-family:Helvetica,Sans-Serif;">
<p>Thanks for fixing this Jan-Mathijs, it works beautifully now!</p>
<p><br>
</p>
<p>Tineke</p>
<p><br>
</p>
<p><br>
</p>
<div style="word-wrap:break-word">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> fieldtrip <fieldtrip-bounces@science.ru.nl> on behalf of Schoffelen, J.M. (Jan Mathijs) <jan.schoffelen@donders.ru.nl><br>
<b>Sent:</b> Friday, November 9, 2018 11:18 AM<br>
<b>To:</b> FieldTrip discussion list<br>
<b>Subject:</b> Re: [FieldTrip] ft_rejectvisual reduces trial length</font>
<div> </div>
</div>
<div>Hi Tineke,
<div class=""><br class="">
</div>
<div class="">This is indeed inappropriate behaviour of the function, which has been tracked down to something going wrong in ft_selectdata. </div>
<div class="">I have submitted a PR <a href="https://github.com/fieldtrip/fieldtrip/pull/873" class="">
https://github.com/fieldtrip/fieldtrip/pull/873</a> on the github-repo which fixes the issue
<a href="https://github.com/fieldtrip/fieldtrip/issues/871" class="">https://github.com/fieldtrip/fieldtrip/issues/871</a></div>
<div class="">I am pretty sure that this fix does not come with unwanted side effects, but since ft_selectdata is used almost everywhere I’d appreciate some moral support before merging.</div>
<div class=""><br class="">
</div>
<div class="">Let me know what you think.</div>
<div class=""><br class="">
</div>
<div class="">Jan-Mathijs</div>
<div class=""><br class="">
</div>
<div class="">PS: for those who are around: please do join Tineke and me this coming Sunday Nov 11, when we will commemorate the centenary of the 1918 armistice with a choral concert at the church of St. Anthony of Padua in Nijmegen. It starts at 15.30, see <a href="http://www.kamerkoormnemosyne.nl" class="">http://www.kamerkoormnemosyne.nl</a></div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">
<div class="" style="word-wrap:break-word">
<div class="" style="word-wrap:break-word">
<div class="" style="word-wrap:break-word">J.M.Schoffelen, MD PhD<br class="">
Senior Researcher, VIDI-fellow - PI, language in interaction<br class="">
Telephone: +31-24-3614793</div>
<div class="" style="word-wrap:break-word">Physical location: room 00.028</div>
<div class="" style="word-wrap:break-word">Donders Centre for Cognitive Neuroimaging, Nijmegen, The Netherlands<br class="">
<br class="">
<br class="">
</div>
</div>
</div>
</div>
</div>
<div class=""><br class="">
</div>
<div class="">
<div>
<blockquote type="cite" class="">
<div class="">On 7 Nov 2018, at 13:28, Snijders, T.M. (Tineke) <<a href="mailto:tineke.snijders@donders.ru.nl" class="">tineke.snijders@donders.ru.nl</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
Hi,</div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
I am using trials of different lengths, which seems to give a problem in ft_rejectvisual. It wasn’t a problem before (I think in 2016) when I did the same analysis.</div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
When using ft_rejectvisual, in the current fieldtrip version in the output data all trial lengths are reduced to the shortest trial-length, cutting away the remainder of the trial. In the command window it gives a warning of ‘inconsistent sampling info’.</div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
Is there a workaround to still get the full trial-lengths for the artifact rejected data? I do want to keep the complete trials at this point.</div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
Thanks,</div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
Tineke</div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:12pt; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<span class="" style="font-size:10pt; font-family:Helvetica,sans-serif">--<span class="Apple-converted-space"> </span><br class="">
Dr T.M. Snijders<br class="">
Research Staff<br class="">
Max Planck Institute for Psycholinguistics, Nijmegen</span><span class="" style="font-size:12pt; font-family:'Times New Roman',serif"></span></p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<span class="" style="font-size:10pt; font-family:Helvetica,sans-serif"><a href="https://mail.ru.nl/owa/redir.aspx?C=aE18Q9YtGk2rr44ef6ljnvavJ_le59EI7kXp3hhsUOBUcLdMm7SXiF0EPl90EamEoz9Ik4FGfek.&URL=http%3a%2f%2fwww.ru.nl%2fpeople%2fdonders%2fsnijders-t" target="_blank" class="">www.ru.nl/people/donders/snijders-t</a></span><span class="" style="font-size:12pt; font-family:'Times New Roman',serif"></span></div>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<span class="" style="font-size:10pt; font-family:Helvetica,sans-serif"><a href="https://mail.ru.nl/owa/redir.aspx?C=aE18Q9YtGk2rr44ef6ljnvavJ_le59EI7kXp3hhsUOBUcLdMm7SXiF0EPl90EamEoz9Ik4FGfek.&URL=http%3a%2f%2fneurobiologyoflanguage.com%2f" target="_blank" class="">http://www.mpi.nl/departments/language-development</a><br class="">
<br class="">
MPI | Wundtlaan 1 | Room 246 | tel 024 35 21246 | PO Box 310 | 6500 AH Nijmegen</span></div>
<p class="MsoNormal" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</p>
<div class="" style="margin-top:0px; margin-bottom:0px; font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<br class="">
</div>
<span class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); float:none; display:inline!important">_______________________________________________</span><br class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<span class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255); float:none; display:inline!important">fieldtrip
mailing list</span><br class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<a href="https://mailman.science.ru.nl/mailman/listinfo/fieldtrip" class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; background-color:rgb(255,255,255)">https://mailman.science.ru.nl/mailman/listinfo/fieldtrip</a><br class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
<a href="https://doi.org/10.1371/journal.pcbi.1002202" class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px; background-color:rgb(255,255,255)">https://doi.org/10.1371/journal.pcbi.1002202</a><br class="" style="font-family:Helvetica,sans-serif; font-size:13.333333015441895px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; background-color:rgb(255,255,255)">
</div>
</blockquote>
</div>
<br class="">
</div>
<br class="">
<br class="">
</div>
</div>
</body>
</html>