[FieldTrip] ft_sourceanalysis of component data

[Schoffelen, J.M. (Jan Mathijs)]

Dear John,

Sorry about this. I think that we disabled this feature at some point, because the original implementation was a bit hacky (and unpredictable in its behavior). In a bout of quality-of-code-perfectionism we probably cleaned up the code, disabled the feature, agreed that we should address it at some point, even remembered to put in an error message … and subsequently forgot about it.

Anyway, after these lame excuses I suggest to try and get this fixed. Thanks for your willingness to contribute. These days our development workflow lives on github, which should make external contributions to the code much more straightforward (github.com/fieldtrip.git<http://github.com/fieldtrip.git> is where the main repo is located). Perhaps you could check out this chunk of documentation, to get on the road: http://www.fieldtriptoolbox.org/development/git).

For this specific issue, I think it would be best to first discuss a bit the requested features before we start changing the code, so I suggest that you create a local fork of the repository, and within it a new branch, which I think you can subsequently 'pull-request’. This allows us to have a location where we can discuss stuff (for now the ‘issues’ feature for the fieldtrip repo is disabled, yet this would be a more natural way for discussing things).

Does that sound like a plan?

Best,
JM





On 25 May 2017, at 23:03, John Iversen <jiversen at ucsd.edu<mailto:jiversen at ucsd.edu>> wrote:

Dear Fieldtrip development team,

I’m doing a long-delayed upgrade of my fieldtrip installation and came across this error.  I’m not sure how long this has / will be the case, but I’d like to know your plans. I am available to help re-enable it if that would make a difference. It’s not a really critical feature for me, but it is something I’d relied on in my analysis. For now, I suppose I can revert to the old version, which I recall did have to massage things to work (it mapped components onto time if I remember correctly).

elseif iscomp
  % FIXME, select the components here
  % FIXME, add the component numbers to the output
  error('the use of component data in ft_sourceanalysis is disabled for the time being: if you encounter this error message and you need this functionality please contact the FieldTrip development team');
end


Thanks,

John

John R. Iversen, PhD
University of California, San Diego
Swartz Center for Computational Neuroscience
Institute for Neural Computation
9500 Gilman Dr #0559
La Jolla, CA 92093
jiversen at ucsd.edu<mailto:jiversen at ucsd.edu>



_______________________________________________
fieldtrip mailing list
fieldtrip at donders.ru.nl<mailto:fieldtrip at donders.ru.nl>
https://mailman.science.ru.nl/mailman/listinfo/fieldtrip




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.science.ru.nl/pipermail/fieldtrip/attachments/20170529/3196fb4f/attachment.html>